]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
shellDBus: Avoid access to undefined properties
authorFlorian Müllner <fmuellner@gnome.org>
Sat, 17 Jun 2017 16:31:34 +0000 (18:31 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Thu, 13 Jul 2017 15:23:54 +0000 (17:23 +0200)
Don't rely on an implicit undefined value of unset parameters to
shut up some warnings.

https://bugzilla.gnome.org/show_bug.cgi?id=781471

js/ui/shellDBus.js

index 9259f8488614bc86778a809e2c3b07cbc65059f3..8c9ff0c2dfc3f9f05a46feaecd5e98de92d5c27b 100644 (file)
@@ -145,15 +145,15 @@ const GnomeShell = new Lang.Class({
         for (let param in params)
             params[param] = params[param].deep_unpack();
 
-        let monitorIndex = -1;
-        if (params['monitor'] >= 0)
-            monitorIndex = params['monitor'];
+        let monitorIndex = params['monitor'] || -1;
+        let label = params['label'] || undefined;
+        let level = params['level'] || undefined;
 
         let icon = null;
         if (params['icon'])
             icon = Gio.Icon.new_for_string(params['icon']);
 
-        Main.osdWindowManager.show(monitorIndex, icon, params['label'], params['level']);
+        Main.osdWindowManager.show(monitorIndex, icon, label, level);
     },
 
     FocusApp: function(id) {